Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legalizer documentation #2620

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

legalizer documentation #2620

wants to merge 8 commits into from

Conversation

KA7E
Copy link
Contributor

@KA7E KA7E commented Jun 19, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the docs Documentation label Jun 19, 2024
@KA7E KA7E requested a review from vaughnbetz June 19, 2024 11:36
@KA7E KA7E marked this pull request as ready for review June 19, 2024 11:36
doc/src/vpr/command_line_usage.rst Outdated Show resolved Hide resolved
doc/src/vpr/command_line_usage.rst Outdated Show resolved Hide resolved
doc/src/vpr/file_formats.rst Show resolved Hide resolved
doc/src/vpr/file_formats.rst Outdated Show resolved Hide resolved
doc/src/vpr/file_formats.rst Show resolved Hide resolved
@vaughnbetz
Copy link
Contributor

Looks good; I have a few suggested changes.

rachelselinar added a commit to rachelselinar/aug-elfPlace that referenced this pull request Jun 20, 2024
Include link to VPR legalizer documentation based on verilog-to-routing/vtr-verilog-to-routing#2620
@KA7E
Copy link
Contributor Author

KA7E commented Jun 21, 2024

@vaughnbetz for expedience I went ahead and added default flat placement file name generation (in a separate PR). Please review both that PR and this one when CI completes.

@vaughnbetz
Copy link
Contributor

Looks good. i added one more comment for the --legalize option which should be easy to resolve.

@vaughnbetz
Copy link
Contributor

@KA7E
Please see the comment above and resolve it so we can get this feature in, as it is described & referenced in a Heart paper now.
To merge this documentation, the feature itself needs to work, and the code for that should be added as soon as possible. I believe the remaining items are:

  1. Add the code for the actual flat placement file parsing and calls to the cluster creation API to make the clustering.
  2. Add a few tests.
  3. Make this small documentation update

If there are more updates required please add to this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants