Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Windows support #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Basic Windows support #66

wants to merge 3 commits into from

Conversation

hargikas
Copy link

Closes Issue #58

This is the first draft of a working fix for a windows console support of a progress bar.

@verigak
Copy link
Owner

verigak commented Mar 15, 2019

This looks like a very heavy handed approach, the original suggestion on #58 was a one line change. Any other windows people care to comment on this?

@hargikas
Copy link
Author

It is heavy because it was the easiest way to hide & show the cursor and also clear the line in the windows console.

You can also choose to go down the path where in windows platform the cursor is always visible and the line is never cleared.

The only problem I saw with that solution is that the display of eta_td becomes a nuance (the printed string is bigger in the beginning and smaller at the end, leaving old characters at the end of the output) .

@hargikas hargikas mentioned this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants