Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New progress bar for unknown amount of iterations in advance #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

farchy
Copy link

@farchy farchy commented Apr 21, 2016

Added a new progress bar for infinite (unknown max) iterations.
Added a test for it in test_progress.py

  • edited relevant README.rst section

@verigak
Copy link
Owner

verigak commented Apr 22, 2016

Hi, this is very interesting, but the implementation can be simplified a lot. You can implement an AdaptiveMixin that overrides percent and progress. Then AdaptiveBar can become a one liner:

class AdaptiveBar(AdaptiveMixin, IncrementalBar): pass

That way you can make any of the existing bars become adaptive.

@farchy
Copy link
Author

farchy commented Apr 26, 2016

ACK, will change the implementation...
Would you prefer that as a new PR or keep working on this?

@verigak
Copy link
Owner

verigak commented Apr 27, 2016

Let's keep working on this one for now and see if we can squash the commits in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants