Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] #95 show which holiday time came from overlaps #105

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

hbrunn
Copy link
Contributor

@hbrunn hbrunn commented Jan 29, 2024

das sieht dann so aus:

image

und 'overlaps' ist ein Link zu einer Listview der überlappenden Urlaube

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1d0ae8b) 89.01% compared to head (b9358d5) 86.03%.
Report is 10 commits behind head on 15.0.

Files Patch % Lines
verdigado_attendance/models/hr_leave_type.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             15.0     #105      +/-   ##
==========================================
- Coverage   89.01%   86.03%   -2.99%     
==========================================
  Files          13       13              
  Lines         173      179       +6     
  Branches       24       25       +1     
==========================================
  Hits          154      154              
- Misses         17       23       +6     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albig albig linked an issue Feb 5, 2024 that may be closed by this pull request
@albig
Copy link
Member

albig commented Feb 5, 2024

Ich komme hier nicht weiter, @hbrunn . Die Seite bleibt weiß nach dem Login.

Im Odoo-Log steht:

2024-02-05 13:02:47,848 1 ERROR odoo-time odoo.http: Exception during JSON request handling. 
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
[...]
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 654, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
AttributeError: 'hr.leave.type' object has no attribute '_get_overlap'

Und auf der Konsole erscheint

web15_1    | > /mnt/extra-addons/verdigado_attendance/models/hr_leave_type.py(39)_get_days_request()
web15_1    | -> for overlap1, overlap2, time in self._get_overlap(
web15_1    | (Pdb) 

@albig
Copy link
Member

albig commented Feb 5, 2024

Mein Fehler. Mir hatte doch OCA/hr-holidays@19e4b48 gefehlt. Danke für den Hinweis. So funktioniert es prima.

@albig albig merged commit 7c8aa72 into verdigado:15.0 Feb 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kranktage während genehmigten Urlaub: bessere Nachvollziehbarkeit
2 participants