Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] #103 allow to configure holiday overtime for sat, sun, holidays #104

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

hbrunn
Copy link
Contributor

@hbrunn hbrunn commented Jan 29, 2024

No description provided.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (629cf13) 89.17% compared to head (1d0ae8b) 89.01%.
Report is 10 commits behind head on 15.0.

❗ Current head 1d0ae8b differs from pull request most recent head 850500d. Consider uploading reports for the commit 850500d to get more accurate results

Files Patch % Lines
verdigado_attendance/models/hr_employee.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             15.0     #104      +/-   ##
==========================================
- Coverage   89.17%   89.01%   -0.16%     
==========================================
  Files          13       13              
  Lines         157      173      +16     
  Branches       23       24       +1     
==========================================
+ Hits          140      154      +14     
- Misses         16       17       +1     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albig
Copy link
Member

albig commented Jan 29, 2024

Das funktioniert sehr gut.

Ein Spezialfall funktioniert nicht:

  • Samstag ist deaktiviert für Höherwertung
  • ist an einem Samstag aber Feiertag (hatten wir zuletzt am 06.01.2024), dann wird keine Höherwertung vorgenommen. Hier müsste der "Feiertag" vorrang haben.

Bekommst Du das abgebildet @hbrunn ?

@hbrunn
Copy link
Contributor Author

hbrunn commented Jan 29, 2024

@albig das sollte jetzt repariert sein

@albig albig merged commit 5c28cb9 into verdigado:15.0 Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Höherwertung von Arbeitszeiten - Konfiguration der Tage (insbesondere Samstag)
2 participants