Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update psm #9443

Merged
merged 1 commit into from
Nov 19, 2024
Merged

deps: Update psm #9443

merged 1 commit into from
Nov 19, 2024

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Nov 15, 2024

[email protected] contains a bug which breaks build for gnullvm targets, with 0.1.24 it's fixed

Description

Testing Instructions

build for gnullvm targets fixed

[email protected] contains a bug which breaks build for gnullvm targets, with 0.1.24 it's fixed
@ognevny ognevny requested a review from a team as a code owner November 15, 2024 06:07
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Nov 15, 2024
@ijjk
Copy link
Member

ijjk commented Nov 15, 2024

Allow CI Workflow Run

  • approve CI run for commit: fe15087

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@anthonyshew
Copy link
Contributor

For posterity, could you provide a link to the bug or its fix?

@ognevny
Copy link
Contributor Author

ognevny commented Nov 15, 2024

@ognevny
Copy link
Contributor Author

ognevny commented Nov 15, 2024

also there was a problem with other gnullvm targets. probably because of old cc dependency

@chris-olszewski
Copy link
Member

chris-olszewski commented Nov 15, 2024

Were you hitting an error while trying to build turbo on your system?

@ognevny
Copy link
Contributor Author

ognevny commented Nov 15, 2024

Were you hitting an error while trying to build turbo on your system?

yes, there was a problem even with x86_64 gnullvm host

@ognevny
Copy link
Contributor Author

ognevny commented Nov 15, 2024

yes, there was a problem even with x86_64 gnullvm host

warning: [email protected]: clang: error: version 'llvm' in target triple 'x86_64-pc-windows-gnullvm' is invalid

error: failed to run custom build command for `psm v0.1.23`

Caused by:
  process didn't exit successfully: `C:\_\B\src\turbo\target\release-turborepo\build\psm-92dffbd669972aa3\build-script-build` (exit code: 1)
  --- stdout
  OPT_LEVEL = Some("3")
  TARGET = Some("x86_64-pc-windows-gnullvm")
  HOST = Some("x86_64-pc-windows-gnullvm")
  cargo:rerun-if-env-changed=CC_x86_64-pc-windows-gnullvm
  CC_x86_64-pc-windows-gnullvm = None
  cargo:rerun-if-env-changed=CC_x86_64_pc_windows_gnullvm
  CC_x86_64_pc_windows_gnullvm = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = Some("clang")
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-gnullvm
  CFLAGS_x86_64-pc-windows-gnullvm = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_gnullvm
  CFLAGS_x86_64_pc_windows_gnullvm = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = Some("-march=nocona -msahf -mtune=generic -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wp,-D__USE_MINGW_ANSI_STDIO=1")
  cargo:rustc-check-cfg=cfg(switchable_stack,asm,link_asm)
  cargo:rustc-cfg=asm
  cargo:rustc-cfg=link_asm
  running: "clang" "-O3" "--target=x86_64-pc-windows-gnullvm" "-ffunction-sections" "-fdata-sections" "--target=x86_64-pc-windows-gnullvm" "-march=nocona" "-msahf" "-mtune=generic" "-O2" "-pipe" "-Wp,-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-Wp,-D__USE_MINGW_ANSI_STDIO=1" "-xassembler-with-cpp" "-DCFG_TARGET_OS_windows" "-DCFG_TARGET_ARCH_x86_64" "-DCFG_TARGET_ENV_gnu" "-o" "C:\\_\\B\\src\\turbo\\target\\release-turborepo\\build\\psm-a61f6fa8e0ef4132\\out\\src/arch/x86_64_windows_gnu.o" "-c" "src/arch/x86_64_windows_gnu.s"
  cargo:warning=clang: error: version 'llvm' in target triple 'x86_64-pc-windows-gnullvm' is invalid

  exit code: 1

  --- stderr


  error occurred: Command "clang" "-O3" "--target=x86_64-pc-windows-gnullvm" "-ffunction-sections" "-fdata-sections" "--target=x86_64-pc-windows-gnullvm" "-march=nocona" "-msahf" "-mtune=generic" "-O2" "-pipe" "-Wp,-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-Wp,-D__USE_MINGW_ANSI_STDIO=1" "-xassembler-with-cpp" "-DCFG_TARGET_OS_windows" "-DCFG_TARGET_ARCH_x86_64" "-DCFG_TARGET_ENV_gnu" "-o" "C:\\_\\B\\src\\turbo\\target\\release-turborepo\\build\\psm-a61f6fa8e0ef4132\\out\\src/arch/x86_64_windows_gnu.o" "-c" "src/arch/x86_64_windows_gnu.s" with args "clang" did not execute successfully (status code exit code: 1).


warning: build failed, waiting for other jobs to finish...
The following warnings were emitted during compilation:

@ognevny
Copy link
Contributor Author

ognevny commented Nov 16, 2024

what's blocking for this PR?

@chris-olszewski chris-olszewski merged commit 7fb5b21 into vercel:main Nov 19, 2024
28 checks passed
@chris-olszewski
Copy link
Member

Thank you for the PR!

what's blocking for this PR?

I just wanted to quick read through the changes in the cc bump included in this commit.

@ognevny ognevny deleted the update-psm branch November 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants