Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for negative globs in globalDeps #8190

Conversation

chris-olszewski
Copy link
Member

Description

Handle exclusions in globalDeps

Testing Instructions

Updated global-deps.t to test negative globs.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:21am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:21am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:21am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:21am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am
rust-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:21am

@chris-olszewski chris-olszewski marked this pull request as ready for review May 21, 2024 21:24
@chris-olszewski chris-olszewski requested a review from a team as a code owner May 21, 2024 21:24
Copy link
Contributor

github-actions bot commented May 21, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 21, 2024

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski force-pushed the chrisolszewski/turbo-3238-support-negative-globs-in-globaldeps branch from 261ee71 to c3ed5f6 Compare May 22, 2024 02:21
@chris-olszewski chris-olszewski enabled auto-merge (squash) May 22, 2024 02:33
@chris-olszewski chris-olszewski merged commit 83eb77b into turborepo_2 May 22, 2024
53 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-3238-support-negative-globs-in-globaldeps branch May 22, 2024 03:03
chris-olszewski added a commit that referenced this pull request May 22, 2024
### Description

Handle exclusions in `globalDeps` 

### Testing Instructions

Updated `global-deps.t` to test negative globs.
chris-olszewski added a commit that referenced this pull request May 28, 2024
### Description

Handle exclusions in `globalDeps` 

### Testing Instructions

Updated `global-deps.t` to test negative globs.
chris-olszewski added a commit that referenced this pull request May 29, 2024
### Description

Handle exclusions in `globalDeps` 

### Testing Instructions

Updated `global-deps.t` to test negative globs.
chris-olszewski added a commit that referenced this pull request May 31, 2024
### Description

Handle exclusions in `globalDeps` 

### Testing Instructions

Updated `global-deps.t` to test negative globs.
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
### Description

Handle exclusions in `globalDeps` 

### Testing Instructions

Updated `global-deps.t` to test negative globs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants