feat: factor engines into global cache key #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3123-root-packagejson-s-engine-should-factor-into-cache
branch
from
c1cf131
to
5d05506
Compare
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
force-pushed
the
turborepo_2
branch
from
74fcf2d
to
0f08755
Compare
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3123-root-packagejson-s-engine-should-factor-into-cache
branch
from
5d05506
to
31952ca
Compare
mehulkar
reviewed
May 22, 2024
chris-olszewski
force-pushed
the
turborepo_2
branch
from
83eb77b
to
28643f5
Compare
chris-olszewski
force-pushed
the
turborepo_2
branch
from
42d43b4
to
e468cb1
Compare
No, we don't include the file hash of the root |
chris-olszewski
force-pushed
the
turborepo_2
branch
from
75abd54
to
4072884
Compare
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3123-root-packagejson-s-engine-should-factor-into-cache
branch
from
31952ca
to
986d423
Compare
mehulkar
approved these changes
May 29, 2024
| @@ -407,14 +426,15 @@ mod test { | |||
| global_file_hash_map: &global_file_hash_map, | |||
| root_external_dependencies_hash: Some("0000000000000000"), | |||
| root_internal_dependencies_hash: Some("0000000000000001"), | |||
| engines: Default::default(), | |||
turborepo-tests/integration/tests/run/single-package/with-deps-run.t
Outdated
Show resolved
Hide resolved
turborepo-tests/integration/tests/run/single-package/with-deps-run.t
Outdated
Show resolved
Hide resolved
turborepo-tests/integration/tests/run/single-package/with-deps-run.t
Outdated
Show resolved
Hide resolved
chris-olszewski
deleted the
chrisolszewski/turbo-3123-root-packagejson-s-engine-should-factor-into-cache
branch
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description Changing the `engines` field in the root `package.json` can affect the execution of tasks so it should affect the global cache. This PR adds the `engines` struct to the global cache key. ### Testing Instructions Added new integration test verifying that changing `engines` results in a cache miss.
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description Changing the `engines` field in the root `package.json` can affect the execution of tasks so it should affect the global cache. This PR adds the `engines` struct to the global cache key. ### Testing Instructions Added new integration test verifying that changing `engines` results in a cache miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the
enginesfield in the rootpackage.jsoncan affect the execution of tasks so it should affect the global cache.This PR adds the
enginesstruct to the global cache key.Testing Instructions
Added new integration test verifying that changing
enginesresults in a cache miss.