Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude scope option for cli #543

Closed
wants to merge 3 commits into from

Conversation

Nikitulb
Copy link

Expected that --ignore flag works like discussed in this thread #445, but I realize that it works with git ignore.
I try to exclude some packages from script executing with --scope flag, but glob doesn't support multi letters pattern like this !(my-package-name). It works only with single character [!p][!a] and this pattern exclude all packages with names like "my-app-package".
So I decided to add new flag --exclude-scope

@Nikitulb Nikitulb requested a review from jaredpalmer as a code owner January 11, 2022 13:15
@vercel
Copy link

vercel bot commented Jan 11, 2022

@Nikitulb is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/96wy8S7455L9UAZc4hY5Za8yYrfV
✅ Preview: https://turbo-site-git-fork-nikitulb-feature-exclude-scope.vercel.sh

@gsoltis gsoltis added the area: ergonomics Issues and features impacting the developer experience of using turbo label Feb 4, 2022
@ndom91
Copy link

ndom91 commented Feb 4, 2022

Would love to see this! Having trouble with ignoring @org/package type packages from our npm scripts. Using --ignore alongside --scope.

@jaredpalmer
Copy link
Contributor

Closing in favor of #696 which fixed "!" in --scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ergonomics Issues and features impacting the developer experience of using turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants