Update to latest CoRIM implementation #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the year in copyrights inside files modified by prior commits this year. Signed-off-by: Sergei Trofimov <[email protected]>
thomas-fossati
approved these changes
Aug 15, 2024
setrofim
force-pushed
the
corim-update
branch
2 times, most recently
from
7ffe18a
to
4f2c85d
Compare
Update to support the latest github.com/veraison/corim, which is (more) aligned with he latest CoRIM spec draft. The latest implementation has the following major changes: - UnsignedCorim's Profiles field (a slice of strings) has been replaced with Profile field (a single string). - Reference value can now only contain a single measurement, so multiple measurements require multiple reference values (each with its own environment). - CBOR keys for DevIdentityKeys and AttestVerifKeys have been swapped to align with the spec (this was a bug in the old implementation). As the latest github.com/veraison/corim requires Go 1.22, the required version for this code base has been bumped to that as well. Signed-off-by: Sergei Trofimov <[email protected]>
Otherwise, copyright year check triggers, causing problems. This is already set for the ci flow, but it seems was not need need for ci-go-cover until now(?) Signed-off-by: Sergei Trofimov <[email protected]>
|
Thank you for your consistent efforts in aligning with the latest of CoRIM draft! I have reviewed these changes and LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support the latest github.com/veraison/corim, which is (more)
aligned with he latest CoRIM spec draft. The latest implementation has
the following major changes:
with Profile field (a single string).
measurements require multiple reference values (each with its own
environment).
to align with the spec (this was a bug in the old implementation).
As the latest github.com/veraison/corim requires Go 1.22, the required
version for this code base has been bumped to that as well.
Additionally: