Fix error when saving an app with no scopes (Fixes #37)

venveo · Aug 13, 2022 · f870d12 · f870d12
1 parent e1070bb
commit f870d12
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 ### Changed
 - Now requires Craft 4 & PHP 8.0.2
 
+## Fixed
+- Fixed saving an app with no scopes producing an error
+
 ### Removed
 - Removed route `oauthclient/authorize/refresh/` use `oauth/authorize/refresh/` instead
 - Removed route `oauthclient/authorize/` use `oauth/authorize/` instead

diff --git a/src/controllers/AppsController.php b/src/controllers/AppsController.php
@@ -139,7 +139,9 @@ public function actionSave(): ?\yii\web\Response
         $appService = Plugin::getInstance()->apps;
 
         $scopes = $request->getBodyParam('scopes');
-        $scopes = implode(',', ArrayHelper::getColumn($scopes, 'scope'));
+        if (is_array($scopes)) {
+            $scopes = implode(',', ArrayHelper::getColumn($scopes, 'scope'));
+        }
 
         $config = [
             'id' => $request->getBodyParam('id'),

diff --git a/src/models/App.php b/src/models/App.php
@@ -37,7 +37,7 @@ class App extends Model
     public ?int $id = null;
     public ?\DateTime $dateCreated = null;
     public ?\DateTime $dateUpdated = null;
-    public $scopes;
+    public string $scopes = '';
     public ?int $userId = null;
     public ?string $provider = null;
     public ?string $name = null;