Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProductVariantPrice custom fields ui inputs #3327

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Jan 21, 2025

Description

2nd attempt of: #3263

Breaking changes

The admin-api schema needs to be updated. The Typescript should not break though, so it should be safe to update.

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 21, 2025 9:17pm

Copy link
Contributor

github-actions bot commented Jan 21, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (michaelbromley)[https://github.com/michaelbromley]
@kevin
Kevin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Draykee
Copy link
Contributor Author

Draykee commented Jan 21, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue where there are changes here.. codegen did it.

I hadn't correctly updated the schema locally and it
turns out that this part was not needed
@michaelbromley michaelbromley merged commit 0d22b25 into vendure-ecommerce:master Jan 21, 2025
27 of 29 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose admin-ui for custom fields on ProductVariantPrice.
2 participants