Add productVariantId,orderId to OrderLine api, orderId column to OrderLine #3291
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I cannot tell you how much time I spent on performance related issues caused by needing access to the
orderId
from anOrderLine
without having access to the rootorder
.Vendure strongly assumes that orderLines and payments are accessed through the order. And normally, that's the case. However, there are a number of scenario's where you might want to access the
orderId
orproductVariantId
without loading those entities. And you might not have the root order entity handy. It's a scenario common to us.Also, Vendure should IMHO optimize for getting all ManyToOne columns easily through GraphQL and code, without having to load the entire entity if all you need is the id. Which IS a common scenario.
I want to push another PR which addreses ALL of the columns and ManyToOne relations, but let's see how this one goes first :-)
Breaking changes
No
Screenshots
Checklist
📌 Always:
👍 Most of the time: