Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a small typo in documentation for ProductVariantSelectorCom… #3205

Conversation

agoransson
Copy link
Contributor

…ponent.

Description

Fixed a small issue in documentation, from:

<vdr-product-variant-selector
  (productSelected)="selectResult($event)"></vdr-product-selector>

to:

<vdr-product-variant-selector
  (productSelected)="selectResult($event)"></vdr-product-variant-selector>

Also updated doc comment for said component.

Breaking changes

No breaking changes, documentation only.

Screenshots

Skärmavbild 2024-11-09 kl  10 53 26

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • [] I have added or updated test cases
  • [] I have updated the README if needed

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 9, 2024 10:06am

Copy link
Contributor

github-actions bot commented Nov 9, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

sonarqubecloud bot commented Nov 9, 2024

@agoransson
Copy link
Contributor Author

agoransson commented Nov 9, 2024

I have read the CLA Document and I hereby sign the CLA

recheck

github-actions bot added a commit that referenced this pull request Nov 9, 2024
@dlhck dlhck added the docs 📖 Documentation fixes or improvements label Nov 9, 2024
@dlhck dlhck merged commit 19d9f2a into vendure-ecommerce:master Nov 9, 2024
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs 📖 Documentation fixes or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants