Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Make registerPageTab work on 'order-list' location (#3173) #3187

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kkerti
Copy link
Contributor

@kkerti kkerti commented Nov 5, 2024

Description

I got into the issue where I wasn't able to add a custom component to location order-list with the registerPageTab provider. Found out that the culprit is the router configuration in admin-ui for the order part. Under the more complex paths with subroutes pathMatch: full is not used, only on more basic pages like login and dashboard.

Issue reference is here: #3173

Breaking changes

If a user has the same order ID like the tab name, that could cause a race condition I assume, but I think this would be unlikely.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 5, 2024 9:34pm

Copy link
Contributor

github-actions bot commented Nov 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kkerti
Copy link
Contributor Author

kkerti commented Nov 5, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

@michaelbromley michaelbromley merged commit 61d808b into vendure-ecommerce:master Nov 8, 2024
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@michaelbromley
Copy link
Member

Thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants