feat(admin-ui): improve facet selector with the code #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -13,4 +13,9 @@ export class FacetValueChipComponent { | |||
| @Input() removable = true; | |||
| @Input() displayFacetName = true; | |||
| @Output() remove = new EventEmitter<void>(); | |||
|
|
|||
| get formattedTitle(): string { | |||
| const facetCode = this.facetValue.facet.code ? `(${this.facetValue.facet.code}) ` : ''; | |||
There was a problem hiding this comment.
What's the need for this line? Do you expect that the facet.code may sometimes be falsy?
There was a problem hiding this comment.
I expect the code to be empty (I've updated the code to reflect this) if it's not requested in the graphql request
b499e03 (example: the product page)
...s/admin-ui/src/lib/core/src/shared/components/facet-value-chip/facet-value-chip.component.ts
Outdated
Show resolved
Hide resolved
|
michaelbromley
merged commit 35892a5
into
vendure-ecommerce:minor
20 of 30 checks passed
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes multiple facets have the same name so it's impossible to distinguish them except with code name
This PR introduces the code name in the facet value chip component
PS: I have not found the way to generate the graphql schema for the admin-ui directory
Breaking changes
No
Test
Add a facet with the same name (but different code) as another one and with the same facetValues
Go to http://localhost:4200/admin/catalog/collections/2
Add the facet in the collection filters
Screenshots
Add a popover to include more context about the facet type
Update the title displayed on hover to include more context about the facet type
Checklist
📌 Always:
👍 Most of the time: