fix(core): Default search plugin query for non-default language fails #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
hans-rollingridges-dev
force-pushed
the
fix/default-search-plugin-query-for-non-default-language-fails
branch
from
7f6d297 to
a0c86c2
Compare
|
Draft PR. Improving e2e tests. |
hans-rollingridges-dev
force-pushed
the
fix/default-search-plugin-query-for-non-default-language-fails
branch
from
1ae77e6 to
6096726
Compare
|
@michaelbromley , is there a benchmark test available to measure the PR impact on shop search query performance? |
|
We have a load testing setup described here: https://github.com/vendure-ecommerce/vendure/tree/master/packages/dev-server#load-testing There's no script specifically for testing the search, but you could create one based on one of the existing scripts. |
hans-rollingridges-dev
force-pushed
the
fix/default-search-plugin-query-for-non-default-language-fails
branch
from
6096726 to
72cdabf
Compare
hans-rollingridges-dev
changed the title
hans-rollingridges-dev
force-pushed
the
fix/default-search-plugin-query-for-non-default-language-fails
branch
from
9e40120 to
c2a688e
Compare
|
Thank you @hans-rollingridges-dev for your excellent work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The - default search plugin - search query for a non-standard language fails. If there is a product variant with non-standard translation, the standard language variant will also be included in the search results. I.e. resulting in search result records with duplicate product variant ID. Depending on the logic for sorting and grouping by, the outcome will be different.
Breaking changes
Screenshots
Checklist
📌 Always:
⚡ Most of the time: