Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(testing): allow Nest to rethrow errors on e2e tests #2514

Merged

Conversation

alexisvigoureux
Copy link
Contributor

@alexisvigoureux alexisvigoureux commented Nov 7, 2023

Description

Allow Nest to rethrow errors on e2e tests
Nest documentation

Screenshots

Before, when an e2e test crashed due to a missing import
Capture d’écran 2023-11-07 à 14 39 09

After
Capture d’écran 2023-11-07 à 14 21 23

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 9e55251
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/654a3f038594a40008330e84

@michaelbromley michaelbromley merged commit 1348ce0 into vendure-ecommerce:master Nov 10, 2023
13 of 14 checks passed
@michaelbromley
Copy link
Member

Oh wow this is amazing, thank you!

@alexisvigoureux alexisvigoureux deleted the e2e-rethrow-errors branch November 10, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants