Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request template #2487

Merged

Conversation

martijnvdbrug
Copy link
Collaborator

@martijnvdbrug martijnvdbrug commented Oct 25, 2023

Not sure if this is something you'd want in the Vendure repo, but it might save you some work reviewing. With this PR template contributors are aware of what they can pay attention to, to have their PR's merged faster.

It renders like this (you can even click the checkboxes after you've created the description):

Description

Please include a summary of the changes and the related issue.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 455e5ef
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/6538b99b5975570008b8c4ac

@michaelbromley michaelbromley merged commit c639ab6 into vendure-ecommerce:master Oct 25, 2023
14 checks passed
@michaelbromley
Copy link
Member

Hi Martijn! Thanks this is a nice little improvement for contributors (and me hopefully :D)

@martijnvdbrug martijnvdbrug deleted the docs/pr-template branch October 26, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants