fix(core): fix configurable operation id decoding when using uuids #2483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2019
Id's were getting JSON stringified when they shouldn't have been. It only worked for integer ids because
JSON.stringify(1) == 1
. For uuids,JSON.stringify("XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX") != "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
.Later, when it uses the values in business logic:
vendure/packages/core/src/common/configurable-operation.ts
Lines 459 to 460 in 218561f
I can't guarantee this doesn't break anything as the change is in a critical area.