fix(payments-plugin): Idempotent 'paid' Mollie webhooks #2462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
Already paid
orderline to Mollie order if it has a value. See more info here about already paid⬆️ We dont want this.
paid
but Vendure order is alreadypaymentSettled
, we don't do anything and return 200. (It was throwing an error). This was the error thrown when anotherpaid
webhook comes in:Failed to process incoming webhook: "Error adding payment to order A47MESUAJY7NVBHV: ORDER_PAYMENT_STATE_ERROR"