fix(admin-ui): Do not load pending search index updates if permissions are insufficient #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are insufficient
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
michaelbromley
requested changes
Oct 17, 2023
packages/admin-ui/src/lib/core/src/providers/alerts/alerts.service.ts
Outdated
Show resolved
Hide resolved
michaelbromley
merged commit 08ad982
into
vendure-ecommerce:master
11 of 14 checks passed
|
Thanks for your help on this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pending-search-index-updatesexecutes a query that returnsforbiddenif neitherReadCatalognorReadProductpermissions are available. This loads to an automatic logout in admin-ui. This change prevents the call by adding a new configuration property to theconfigureAlertmethod. If any permission passed viarequiredPermissionsexists the alert is being created.If not the alert will be registered if at some point the permission is added and
userStatusupdates.Closes #2456