Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments-plugin): List missing available Mollie payment methods for orders api #2435

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix(payments-plugin): List missing available Mollie payment methods for orders api #2435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb26f7f
fix(payments-plugin): list available methods for orders api
martijnvdbrug Oct 10, 2023
0ddfbd4
fix(payments-plugin): mock request with resource paramter
martijnvdbrug Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/payments-plugin/e2e/mollie-payment.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ describe('Mollie payments (with useDynamicRedirectUrl set to true)', () => {

it('Should get available paymentMethods', async () => {
nock('https://api.mollie.com/')
.get('/v2/methods')
.get('/v2/methods?resource=orders')
.reply(200, mockData.molliePaymentMethodsResponse);
await shopClient.asUserWithCredentials(customers[0].emailAddress, 'test');
const { molliePaymentMethods } = await shopClient.query(GET_MOLLIE_PAYMENT_METHODS, {
Expand Down
3 changes: 2 additions & 1 deletion packages/payments-plugin/src/mollie/mollie.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,8 @@ export class MollieService {
throw Error(`No apiKey configured for payment method ${paymentMethodCode}`);
}
const client = createMollieClient({ apiKey });
const methods = await client.methods.list();
// We use the orders API, so list available methods for that API usage
const methods = await client.methods.list({resource: 'orders'});
return methods.map(m => ({
...m,
code: m.id,
Expand Down
Loading