fix(payments-plugin): Fix null access error in BraintreePlugin

Gracefully handles the case where the call to create a sale fails, and there is no `transaction` object available.
vendure-ecommerce · Jan 21, 2025 · 627d930 · 627d930
1 parent e22c601
commit 627d930
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/payments-plugin/src/braintree/braintree.handler.ts b/packages/payments-plugin/src/braintree/braintree.handler.ts
@@ -106,12 +106,12 @@ async function processPayment(
         },
     });
     const extractMetadataFn = pluginOptions.extractMetadata ?? defaultExtractMetadataFn;
-    const metadata = extractMetadataFn(response.transaction);
+    const metadata = response.transaction && extractMetadataFn(response.transaction);
     if (!response.success) {
         return {
             amount,
             state: 'Declined' as const,
-            transactionId: response.transaction.id,
+            transactionId: response.transaction?.id,
             errorMessage: response.message,
             metadata,
         };