-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Built-in control flow syntax (#26) #27
feat: Add support for Built-in control flow syntax (#26) #27
Conversation
Closes #26 Because I needed to use imports that don't exist in Angular <= 16 I had to bump up the minimum required version for Angular, Node and TypeScript which leads to a major update in case we proceed on merging it. @michaelbromley how would you prefer to proceed? |
Wow amazing! Thank you! One small thing: the test fail in CI because the workflow file specifies node v16.x Could you update this as part of this PR to at least 18.x (you could also add v20.x so we are covering that version too). Oh also let's add a row to the compatibility table for v9.x / Angular v17 |
15e6403
to
9e03b11
Compare
oups, the workflow file slipped my attention. I updated now the node versions and the versions in the compatibility table in the README.md |
Thanks! There's an annoying CI failure here though: https://github.com/vendure-ecommerce/ngx-translate-extract/actions/runs/6944504102/job/18892782835?pr=27#step:5:9 |
Great! I'll do a release shortly 👍 |
Thank you very much! In the meantime I will make some more tests in a project and fingers crossed there are no strange edge cases. |
BREAKING CHANGE