Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seo improvements #98

Merged
merged 9 commits into from
Aug 16, 2024
Merged

feat: seo improvements #98

merged 9 commits into from
Aug 16, 2024

Conversation

Victor-Salomon
Copy link
Collaborator

Add all the missing SEO files, images, manifests.

It's the first time I'm implementing this and I'm not an expert in these SEO files/tag.
I have based this PR on the official Next Js documentation & some articles I've read.

Open to discussion

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turtle-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:03pm
turtle-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:03pm

@noahjoeris
Copy link
Collaborator

Crazy I have never seen most of the settings before 😅 But I trust your research.
But I always thought nextjs already handles SEO mostly for you no?

@noahjoeris
Copy link
Collaborator

And the app/public/android-chrome-512x512.png is 2.14MB large. Can we get it smaller?

@Victor-Salomon
Copy link
Collaborator Author

I was aware of some parts of this but I was impressed about "all" that needed to be added.
Next JS optimises many SEO things for us yes. These are more like Browsers crawling 'requirements'.

Let me check this large image. I've compressed everything so I'm surprised this one is still that heavy.

Copy link
Collaborator

@noahjoeris noahjoeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@NunoAlexandre
Copy link
Collaborator

I was aware of some parts of this but I was impressed about "all" that needed to be added. Next JS optimises many SEO things for us yes. These are more like Browsers crawling 'requirements'.

Let me check this large image. I've compressed everything so I'm surprised this one is still that heavy.

@Victor-Salomon tinypng is a really nice site to compress png shall you need one :)

@Victor-Salomon Victor-Salomon merged commit 2ece08e into main Aug 16, 2024
5 checks passed
@Victor-Salomon Victor-Salomon deleted the feat/seo-setup branch August 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants