Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve tx duration estimate #92

Merged
merged 3 commits into from
Aug 13, 2024
Merged

feat: Improve tx duration estimate #92

merged 3 commits into from
Aug 13, 2024

Conversation

NunoAlexandre
Copy link
Collaborator

@NunoAlexandre NunoAlexandre commented Aug 13, 2024 •
edited
Loading

Transfers from DOT -> ETH take 30 min to 4 hours but currently we just '~30min' for both transfer directions which is confusing and misleading for users.

Here we show ~30 min to 4 hours for DOT -> ETH and ~30 min for ETH -> DOT.

@NunoAlexandre
feat: Better estimate for different directions
6f0a592 
Transfers from DOT -> ETH take 30 min to 4 hours but currently we just
'~30min' for both transfer directions which is confusing and misleading
for users.
@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turtle-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:39pm
turtle-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:39pm

@NunoAlexandre NunoAlexandre self-assigned this Aug 13, 2024
noahjoeris
noahjoeris approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@noahjoeris noahjoeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I left some minor requests. Feel free to ignore.

app/src/components/FeesPreview.tsx Outdated Show resolved Hide resolved
app/src/utils/transfer.ts Outdated Show resolved Hide resolved
Victor-Salomon
Victor-Salomon approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@Victor-Salomon Victor-Salomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me.

I looked into the naming as I wanted to avoid naming overlaps in the function that estimate the bridge transfer and it's all ok.

@NunoAlexandre NunoAlexandre changed the title feat: Better estimate for different directions feat: Improve tx duration estimate Aug 13, 2024
@NunoAlexandre NunoAlexandre merged commit e0bcf93 into main Aug 13, 2024
4 of 5 checks passed
@NunoAlexandre NunoAlexandre deleted the feat/ad-hoc-estimate branch August 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-Salomon Victor-Salomon Victor-Salomon approved these changes

@noahjoeris noahjoeris noahjoeris approved these changes

Assignees

@NunoAlexandre NunoAlexandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NunoAlexandre @noahjoeris @Victor-Salomon