fix: ocelloids upgrade #258
Open
+142
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NunoAlexandre
approved these changes
Jan 23, 2025
| ): boolean => { | ||
| return transfer.token.id === Polkadot.DOT.id && isParachainToParachain(transfer) | ||
| enum xcmNotificationType { | ||
| Sent = 'xcm.sent', |
There was a problem hiding this comment.
Question that I might answer myself later but that the introduction of this new enum interfere with old data on storage? I guess it doesn't matter as much since it's just about an ongoing tx.
There was a problem hiding this comment.
Nope, the reason is the xcmNotificationType enum has been removed in Ocelloids SDK v2.4.x.
I created this enum to avoid checking many times on the notification type since it is not typed anymore by Ocelloids.
Before v2.4.x:
From v2.4.x:
We never store this data, so no way to interfere with storage 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains Ocelloids last version which fixes unsupported and missing tracking paths:
And includes: