Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check to avoid exception during initializing #7

Closed
wants to merge 1 commit into from

Conversation

laserdark
Copy link

For lacking null check during initialization, the plugin would throw an exception, sometimes, which may cause the layout of KCV not responding until one complete sortie back to homeport.
And this branch might solve the problem.

@veigr
Copy link
Owner

veigr commented Jul 3, 2020

この PR の内容では、実際に Models.Maps.MapInfos が null であった場合にマップ コンボボックスが動作しなくなってしまうため、望ましくありません。
より良い改善策は Models.Maps.MapInfos 等の初期化通知を作成し、それをトリガーとして SettingsViewModel.Initialize() を呼ぶ事だと考えられます。

ひとまず Issue #8 を立てましたので、暇があるときに手を付けることにします。

報告ありがとうございました。

@veigr veigr closed this Jul 3, 2020
@laserdark laserdark deleted the bugfix/initial-null-check branch April 4, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants