Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script/bootstrap, script/cibuild, and 2 GH Workflows: Anchore-… #48

Merged

Conversation

stephengtuggy
Copy link
Contributor

…Container-Scan.yml and gh-actions-pr.yml

Thank you for submitting a pull request and becoming a contributor to Vega Strike's Build System Docker Images.

Please answer the following:

Code Changes:

  • CI Change

Issues:
N/A

Purpose:

  • What is this pull request trying to do? Fix Python bootstrapping on Rocky Linux 8.8/8.9 etc. Also, correct script/cibuild to build Docker images, regardless of whether this is a Release workflow run or not.
  • What release is this for?
  • Is there a project or milestone we should apply this to?

@stephengtuggy stephengtuggy marked this pull request as ready for review April 25, 2024 03:39
@stephengtuggy stephengtuggy self-assigned this Apr 25, 2024
@stephengtuggy stephengtuggy added the bug Something isn't working label Apr 25, 2024
@stephengtuggy
Copy link
Contributor Author

@vegastrike/core-reviewers : I am merging this now, because I need it urgently. Feel free to review the PR after the fact though. 😄 (And we can fix anything that you guys spot at that point.)

@stephengtuggy stephengtuggy requested a review from a team April 25, 2024 03:42
@stephengtuggy stephengtuggy merged commit 2e11537 into vegastrike:master Apr 25, 2024
60 checks passed
@@ -1198,6 +1198,7 @@ function bootstrapOnRedHat ()
dnf -y install \
git \
cmake \
python3.11-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - we did python3-devel because it should be the latest on the platform, as opposed to tied to a specific version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I remember. However, that doesn't seem to work on Rocky Linux 8.9 for some reason. Maybe because they're keeping Python 3.9 as the default version, for backward compatibility with other 8.x releases.

@BenjamenMeyer
Copy link
Member

aside from the python3-devel comment, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants