fixmes

vega · May 20, 2024 · 75907da · 75907da
1 parent acbaeb1
commit 75907da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/compile/format.ts b/src/compile/format.ts
@@ -61,6 +61,7 @@ export function formatSignalRef({
   const field = fieldToFormat(fieldOrDatumDef, expr, normalizeStack);
   const type = channelDefType(fieldOrDatumDef);
 
+  // FIXME: this `config.customFormatTypes` clause should wrap all code relevant to formatCustomType
   if (format === undefined && formatType === undefined && config.customFormatTypes) {
     if (type === 'quantitative') {
       if (normalizeStack && config.normalizedNumberFormatType)
@@ -337,6 +338,7 @@ function wrapFormatExprToHandleInvalidValues({
   return mainFormatExpr;
 }
 
+// FIXME: we shouldn't really export this to be called directly
 export function binFormatExpression(
   startField: string,
   endField: string,

diff --git a/src/compile/mark/encode/tooltip.ts b/src/compile/mark/encode/tooltip.ts
@@ -100,6 +100,7 @@ export function tooltipData(
 
     let value: string;
 
+    // FIXME: why doesn't this file just call formatSignalRef directly?
     if (isXorY(channel)) {
       const channel2 = channel === 'x' ? 'x2' : 'y2';
       const fieldDef2 = getFieldDef(encoding[channel2]);