Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adds Vega-Altair Theme Test #3630

Merged
merged 40 commits into from
Oct 17, 2024
Merged

docs: Adds Vega-Altair Theme Test #3630

merged 40 commits into from
Oct 17, 2024

Commits on Oct 3, 2024

  1. docs: Adds altair_theme_test.py 

    Related: #3519 (comment)
    @dangotbanned
    dangotbanned committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    db3557d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. chore: Vendor alt.utils.html.STANDARD template 

    Planning to adapt this with changes from `index.html`
    @dangotbanned
    dangotbanned committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bc60d23 View commit details
    Browse the repository at this point in the history

  2. refactor: Remove static conditionals in template

    @dangotbanned
    dangotbanned committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ffc8345 View commit details
    Browse the repository at this point in the history

  3. feat: Add theme select input

    @dangotbanned
    dangotbanned committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4b4d4fd View commit details
    Browse the repository at this point in the history

  4. chore: Add temporary render_write helper

    @dangotbanned
    dangotbanned committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bad2bcf View commit details
    Browse the repository at this point in the history

  5. refactor: Move chart concat into function

    @dangotbanned
    dangotbanned committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f7aeef8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. feat(DRAFT): Adapt more of index.html script 

    **This doesn't work yet**.
The url params do work, but calling refresh doesn't
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0fae2ab View commit details
    Browse the repository at this point in the history

  2. fix: Pass theme name to correct property

    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    f6971de View commit details
    Browse the repository at this point in the history

  3. docs: Ensure all charts have tooltips

    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d59ce76 View commit details
    Browse the repository at this point in the history

  4. docs: Adds static vega-altair_theme_test.html 

    #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    23a2f91 View commit details
    Browse the repository at this point in the history

  5. ci: Temp pin mypy 

    https://github.com/vega/altair/actions/runs/11194134028/job/31120421062?pr=3630
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8c6544c View commit details
    Browse the repository at this point in the history

  6. revert: Remove temp mypy pin 

    8c6544c
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0b07f27 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into altair-theme-test

    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3e72fe1 View commit details
    Browse the repository at this point in the history

  8. docs: Link to vega-altair_theme_test.html in #chart-themes

    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d1ea691 View commit details
    Browse the repository at this point in the history

  9. refactor: Remove polars dependency 

    #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    436a65d View commit details
    Browse the repository at this point in the history

  10. refactor: Move entire chart definition to alt_theme_test 

    Resolve part of #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    f466d8a View commit details
    Browse the repository at this point in the history

  11. refactor: Move imports inline

    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    85ba0b6 View commit details
    Browse the repository at this point in the history

  12. feat: Adds tools.codemod.py 

    Related #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    1773498 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. feat: Adds .. altair-code-ref:: directive 

    Very lightweight solution for #3630 (comment)
Also related to #3570
    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    1945d2b View commit details
    Browse the repository at this point in the history

  2. docs: Add folding code block for Vega-Altair Theme Test 

    #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    8221d6c View commit details
    Browse the repository at this point in the history

  3. fix(typing): Remove unused type ignore 

    Was only needed prior to using a version guard
    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    db14314 View commit details
    Browse the repository at this point in the history

  4. fix(typing): Add patch for vl-convert-python=1.7.0 

    Will open a new PR to merge this, related to vega/vl-convert#185
    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    aa00dc1 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into altair-theme-test

    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    712c646 View commit details
    Browse the repository at this point in the history

  6. refactor: Render html after generate_api_docs

    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    6e1ca94 View commit details
    Browse the repository at this point in the history

  7. style: Trim some whitespace

    @dangotbanned
    dangotbanned committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    3a5801e View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merge branch 'main' into altair-theme-test

    @dangotbanned
    dangotbanned authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    42491c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'main' into altair-theme-test

    @dangotbanned
    dangotbanned authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b04dc02 View commit details
    Browse the repository at this point in the history

  2. refactor: Factor out vega_datasets dependency 

    #3630 (comment)
    @dangotbanned
    dangotbanned committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    6568cdf View commit details
    Browse the repository at this point in the history

  3. fix: Run generate-schema-wrapper 

    https://github.com/vega/altair/actions/runs/11316432875/job/31468704488?pr=3630
    @dangotbanned
    dangotbanned committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    85a2a4f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix(typing): Add type ignore 

    Really unsure why `mypy` has suddenly started complaining about this
    @dangotbanned
    dangotbanned committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2fe68f8 View commit details
    Browse the repository at this point in the history

  2. feat(DRAFT): Adds Functional altair-pyscript directive 

    - Quick & dirty version
- Pushing to have something for regression testing while I finalize the directive api
    @dangotbanned
    dangotbanned committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0694233 View commit details
    Browse the repository at this point in the history

  3. revert: Remove generate_static_docs 

    Reverts main part of 6e1ca94
Not needed now that `pyscript` is working
    @dangotbanned
    dangotbanned committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6803368 View commit details
    Browse the repository at this point in the history

  4. refactor: Rewrite as altair-theme 

    - Way less dependent on constants
- Similar api to `altair-code-ref`
- Leaving the door open for future potential `pyscript` use-cases
  - This is purely concerned with the theme switching
    @dangotbanned
    dangotbanned committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    99400d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. feat: Support :summary: in altair-theme 

    1/3 of https://github.com/vega/altair/pull/3630/files#r1801072565
    @dangotbanned
    dangotbanned committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cbdf854 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. docs: Add warning for ast.unparse use

    @dangotbanned
    dangotbanned committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7cf627d View commit details
    Browse the repository at this point in the history

  2. refactor: Adds tools.codemod.Ruff 

    #3630 (comment)

**Introduces no new behavior**.
    @dangotbanned
    dangotbanned committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0615228 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. docs: Redesign to fit User Guide template 

    Mostly just following up on [notes](#3630 (comment))
    @dangotbanned
    dangotbanned committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    567796e View commit details
    Browse the repository at this point in the history

  2. revert: Remove THEME_TEST_TEMPLATE, render_theme_test 

    Should have been included in 6803368
    @dangotbanned
    dangotbanned committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c82ecbf View commit details
    Browse the repository at this point in the history

  3. docs: Adds *Built-in Themes* section 

    Feel like it was too easy to miss the `<details>` alone
    @dangotbanned
    dangotbanned committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    092fe09 View commit details
    Browse the repository at this point in the history

  4. revert: Remove vega-altair_theme_test.html 

    No longer needed
    @dangotbanned
    dangotbanned committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1987542 View commit details
    Browse the repository at this point in the history