quick fix for install runner failing and doing a graceful shutdown

veertuinc · Dec 17, 2024 · 97407ba · 97407ba
1 parent 2077495
commit 97407ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.11.1
+0.11.2
diff --git a/plugins/handlers/github/github.go b/plugins/handlers/github/github.go
@@ -919,9 +919,9 @@ func Run(
 		logger.DebugContext(pluginCtx, "installing github runner inside of vm")
 		installRunnerErr = ankaCLI.AnkaRun(pluginCtx, "./install-runner.bash")
 		if installRunnerErr != nil {
-			// logger.ErrorContext(pluginCtx, "error executing install-runner.bash", "err", installRunnerErr)
+			logger.ErrorContext(pluginCtx, "error executing install-runner.bash", "err", installRunnerErr)
 			retryChannel <- true
-			return pluginCtx, fmt.Errorf("error executing install-runner.bash: %s", installRunnerErr.Error())
+			return pluginCtx, nil // do not return error here; curl can fail and we need to retry
 		}
 		// Register runner
 		select {