Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skillet stuff #890

Open
wants to merge 25 commits into
base: 1.19
Choose a base branch
from
Open

Skillet stuff #890

wants to merge 25 commits into from

Conversation

MehVahdJukaar
Copy link
Contributor

This PR does the following:

  • Add skillet flipping animation
  • Makes skillet use Item Renderer instead of baked models while still keeping it json model based to easily position it with blcokbench.
  • Adds skillet cook bar while cooking (replaces durability bar there)
  • replaces various instances of InteractionResult.SUCCESS with the correct .sideSuccess(level.isClientSide)
  • simplifies some logic around the above mentioned code.

Also i realized i accidentally worked on the 1.19 branch. This PR should be able to be cherry picked into 1.20 main aswell with minimal changes (A single argument in ISTER method changed in newer forge)

vectorwing and others added 25 commits July 19, 2023 22:51
@vectorwing
Bump versions, update meta
22f2a5d
@vectorwing
Merge branch '1.19' into update/1.3
b981afe
@vectorwing
Enqueue everything in common setup
2a4edb5
@vectorwing
Update Basket methods
f24e98c
@vectorwing
Merge branch '1.19' into update/1.3
596e7d8
@vectorwing
Update cutting board to accept item stacks
b062111 
- Cutting board can now hold 64 items at a time
- Items are still processed one by one
- Item stacks are displayed as an item pile, like in Skillets
- Off-hand interactions were removed
@vectorwing
Show remaining items to cut on the status bar
947fe1a
@vectorwing
Allow user to increment the board's stack with more items
ee4b80f
@vectorwing
Update changelog with beta test info
c2181a0
@vectorwing
Update changelog and bump to "beta1"
e2b413c
@vectorwing
Update comparator signal, fix dupe bug
410baed
@vectorwing
Simplify cutting board's add/remove methods
764393b
@vectorwing
Make most board actions server-side (WIP)
d630a9d
@vectorwing
Update and simplify cutting particles
d84229a
@vectorwing
Add custom subtitles for cutting board actions
4a3bc1a
@vectorwing
Add subtitle to tool carving
f0ef3c2
@vectorwing
Clean up imports
ffa01b1
@vectorwing
Fix empty board/hand showing invalid item message
d5275b1
@MehVahdJukaar
Very awesome skillet stuff. Flipping included
ba812de
@MehVahdJukaar
fixed skillet bar
a1468ee
@MehVahdJukaar
skillet stuff
89fe63b
@MehVahdJukaar
added decorative blocks braziers to heat sources tag
17845eb
@MehVahdJukaar
use side success instead of SUCCESS. Simplified some logic there too.
2e0da23
@MehVahdJukaar
skillet block flip
2b15350
@MehVahdJukaar
skillet flip sound
3af7fab
@MehVahdJukaar
Copy link
Contributor Author

In last commits I added the following:

  • Replaced all RegistryObject fields with Supplier fields. This is just so multi loader addons can reference both versions registries directly. Same was done for Configuration class
  • Added skillet block flipping and sound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MehVahdJukaar @vectorwing