Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SILKIT-1525: Use bulk-update endpoint of dashboard backend service #71

Merged
merged 1 commit into from
Jul 15, 2024
Merged

SILKIT-1525: Use bulk-update endpoint of dashboard backend service #71

merged 1 commit into from
Jul 15, 2024

Conversation

VDanielEdwards
Copy link
Member

@VDanielEdwards VDanielEdwards commented Jul 4, 2024 •
edited
Loading

Subject

These changes allow the dashboard client in SIL Kit to use the bulk-update endpoint (currently only available in a feature branch of the dashboard that is not publically available).

It allows for much larger simulations, as multiple changes can be combined into a single HTTP request.

Instructions for review / testing

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards self-assigned this Jul 4, 2024
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 11:41 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 4, 2024 11:41 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 11:41 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 11:42 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 11:42 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards force-pushed the silkit-1525_dashboard_performance_bulk_update branch from 1edfe2c to 605e8be Compare July 4, 2024 12:01
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 4, 2024 12:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 4, 2024 12:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 12:03 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 4, 2024 12:03 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 12:03 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 12:03 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 4, 2024 12:03 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 07:30 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 07:30 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 07:30 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 07:30 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 07:30 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 07:30 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 07:30 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 09:31 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 09:31 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 09:31 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 09:31 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 8, 2024 09:31 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 8, 2024 09:31 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards force-pushed the silkit-1525_dashboard_performance_bulk_update branch from b6caad7 to 82852fa Compare July 12, 2024 08:23
@VDanielEdwards
Copy link
Member Author

LGTM (except the obsolete comment)

Also removed the obsolete documentation changes, and reworded the changelog entry.

@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 12, 2024 08:24 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards had a problem deploying to public-github-runners July 15, 2024 08:33 — with GitHub Actions Failure
@VDanielEdwards VDanielEdwards force-pushed the silkit-1525_dashboard_performance_bulk_update branch from 82852fa to e907833 Compare July 15, 2024 11:20
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards temporarily deployed to public-github-runners July 15, 2024 11:20 — with GitHub Actions Inactive
@VDanielEdwards VDanielEdwards merged commit 1b4dd81 into main Jul 15, 2024
9 checks passed
@VDanielEdwards VDanielEdwards deleted the silkit-1525_dashboard_performance_bulk_update branch July 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NadegeNag NadegeNag NadegeNag left review comments

@KonradBkd KonradBkd KonradBkd approved these changes

Assignees

@VDanielEdwards VDanielEdwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VDanielEdwards @KonradBkd @NadegeNag