Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 4.0.55 #147

Merged
merged 1 commit into from
Nov 15, 2024
Merged

bump version to 4.0.55 #147

merged 1 commit into from
Nov 15, 2024

Conversation

KonradBkd
Copy link
Contributor

Bump SilKitVersion.cmake + Changelog to 4.0.55

@KonradBkd KonradBkd requested a review from MariusBgm November 14, 2024 15:16
@VDanielEdwards VDanielEdwards requested review from VDanielEdwards and removed request for MariusBgm November 14, 2024 15:46
@VDanielEdwards
Copy link
Member

VDanielEdwards commented Nov 14, 2024

We should add version bump as the last step of a successful delivery. We could even automate the PR creation. I'll create an internal issue for this.

@MariusBgm
Copy link
Collaborator

We should add version bump as the last step of a successful delivery. We could even automate the PR creation. I'll create an internal issue for this.

I second this. should be easy enough to automate

@KonradBkd
Copy link
Contributor Author

We should add version bump as the last step of a successful delivery. We could even automate the PR creation. I'll create an internal issue for this.

I second this. should be easy enough to automate

Downside is that we have to guess that the next version is a Patch increment. If a some other increment happens, we have to adjust. Looking back, this is not a real problem though.

@VDanielEdwards
Copy link
Member

We should add version bump as the last step of a successful delivery. We could even automate the PR creation. I'll create an internal issue for this.

I second this. should be easy enough to automate

Downside is that we have to guess that the next version is a Patch increment. If a some other increment happens, we have to adjust. Looking back, this is not a real problem though.

We could also put the bump into a separate workflow_dispatch workflow, which can be parametrized with an option to select the kind of bump. This workflow would be able to see the same secrets as the tagging workflow.

@KonradBkd KonradBkd merged commit d23f3a2 into main Nov 15, 2024
12 checks passed
@KonradBkd KonradBkd deleted the dev_version_bump_4_0_55 branch November 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants