Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(gcs sink): add retry for 408 http error #21449

Open
wants to merge 2 commits into from
+4 −0
Open

enhancement(gcs sink): add retry for 408 http error #21449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2c162
enhancement(gcs sink): add retry for 408 http error
benjamin-awd Oct 8, 2024
684a660
fix changelog fragment naming
jszwedko Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/21447-gcs-sink-retry-on-http-error-408.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Adds retry support for the 408 HTTP error (request timed out) for the GCS sink.

authors: benjamin-awd
1 change: 1 addition & 0 deletions src/sinks/gcs_common/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ impl RetryLogic for GcsRetryLogic {

match status {
StatusCode::UNAUTHORIZED => RetryAction::Retry("unauthorized".into()),
StatusCode::REQUEST_TIMEOUT => RetryAction::Retry("request timeout".into()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, can we also update the retry policy docs for the affected GC sinks?

StatusCode::TOO_MANY_REQUESTS => RetryAction::Retry("too many requests".into()),
StatusCode::NOT_IMPLEMENTED => {
RetryAction::DontRetry("endpoint not implemented".into())
Expand Down
Loading