-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Update install.sh workflow to not publish to AWS #21412
Conversation
We no longer host install.sh in AWS S3 but instead reference it from GitHub. This change happened a while ago, but we apparently never updated the CI wrokflow; we just never noticed since we haven't changed the script since then. Signed-off-by: Jesse Szwedko <[email protected]>
.github/workflows/install-sh.yml
Outdated
runs-on: ubuntu-20.04 | ||
timeout-minutes: 5 | ||
steps: | ||
- run: sudo apt-get install --yes curl bc | ||
- run: curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev | bash -s -- -y | ||
- run: bash distribution/install.sh -- -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely curiosity- why is the explicit bash
call needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, given the file does have the executable bit (x
) it technically isn't needed. I just have a habit of using bash
with anything ending in .sh
since those frequently aren't executable.
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.53s Total Time |
Regression Detector ResultsRun ID: 811eaa51-179e-47da-a0e4-de1e1c55f8a6 Metrics dashboard Baseline: 03b3372 Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | -0.18 | [-7.15, +6.78] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
✅ | syslog_log2metric_humio_metrics | ingress throughput | +5.30 | [+5.18, +5.42] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +2.22 | [+2.04, +2.40] | |
➖ | splunk_hec_route_s3 | ingress throughput | +2.18 | [+1.88, +2.49] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +2.15 | [+1.93, +2.37] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +2.09 | [+1.96, +2.22] | |
➖ | http_elasticsearch | ingress throughput | +1.93 | [+1.79, +2.07] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +1.91 | [+1.80, +2.01] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +1.07 | [+0.85, +1.29] | |
➖ | http_to_http_acks | ingress throughput | +0.92 | [-0.30, +2.14] | |
➖ | syslog_loki | ingress throughput | +0.81 | [+0.69, +0.93] | |
➖ | http_to_http_noack | ingress throughput | +0.13 | [+0.05, +0.20] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.13 | [+0.01, +0.25] | |
➖ | http_to_http_json | ingress throughput | +0.03 | [-0.02, +0.08] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.03 | [-0.07, +0.14] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.00 | [-0.09, +0.09] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.01 | [-0.10, +0.09] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.01 | [-0.08, +0.07] | |
➖ | otlp_http_to_blackhole | ingress throughput | -0.05 | [-0.20, +0.11] | |
➖ | http_to_s3 | ingress throughput | -0.05 | [-0.33, +0.23] | |
➖ | file_to_blackhole | egress throughput | -0.18 | [-7.15, +6.78] | |
➖ | socket_to_socket_blackhole | ingress throughput | -0.36 | [-0.42, -0.30] | |
➖ | fluent_elasticsearch | ingress throughput | -0.88 | [-1.38, -0.37] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.90 | [-1.00, -0.79] | |
➖ | http_text_to_http_json | ingress throughput | -0.92 | [-1.06, -0.78] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -2.15 | [-2.23, -2.07] | |
❌ | syslog_humio_logs | ingress throughput | -5.13 | [-5.30, -4.96] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector ResultsRun ID: 5dc6d279-563e-469c-93bb-7914ba9e89a0 Metrics dashboard Baseline: 7086dfc Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
❌ | file_to_blackhole | egress throughput | -15.18 | [-21.87, -8.48] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +2.50 | [+2.41, +2.58] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +1.86 | [+1.77, +1.94] | |
➖ | syslog_humio_logs | ingress throughput | +1.74 | [+1.65, +1.84] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +1.37 | [+1.18, +1.56] | |
➖ | splunk_hec_route_s3 | ingress throughput | +0.80 | [+0.49, +1.10] | |
➖ | http_elasticsearch | ingress throughput | +0.77 | [+0.59, +0.95] | |
➖ | socket_to_socket_blackhole | ingress throughput | +0.73 | [+0.67, +0.80] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.67 | [+0.59, +0.75] | |
➖ | fluent_elasticsearch | ingress throughput | +0.55 | [+0.06, +1.03] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.41 | [+0.22, +0.61] | |
➖ | syslog_loki | ingress throughput | +0.29 | [+0.22, +0.35] | |
➖ | otlp_http_to_blackhole | ingress throughput | +0.05 | [-0.09, +0.19] | |
➖ | http_to_http_noack | ingress throughput | +0.03 | [-0.01, +0.07] | |
➖ | http_to_http_json | ingress throughput | +0.02 | [-0.01, +0.05] | |
➖ | http_to_s3 | ingress throughput | +0.01 | [-0.25, +0.28] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.01 | [-0.08, +0.10] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.08, +0.09] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.01 | [-0.10, +0.08] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.03 | [-0.16, +0.11] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.64 | [-0.75, -0.52] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.65 | [-0.77, -0.53] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.21 | [-1.32, -1.09] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -2.03 | [-2.16, -1.90] | |
➖ | http_to_http_acks | ingress throughput | -2.24 | [-3.46, -1.02] | |
➖ | http_text_to_http_json | ingress throughput | -2.72 | [-2.84, -2.60] | |
❌ | file_to_blackhole | egress throughput | -15.18 | [-21.87, -8.48] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
Regression Detector ResultsRun ID: 48aa9535-7440-4cf7-88a7-45f8d903decd Metrics dashboard Baseline: f9b07db Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
❌ | file_to_blackhole | egress throughput | -16.30 | [-22.38, -10.21] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | syslog_humio_logs | ingress throughput | +2.12 | [+2.00, +2.23] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +1.74 | [+1.63, +1.85] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +1.60 | [+1.47, +1.73] | |
➖ | syslog_loki | ingress throughput | +1.48 | [+1.40, +1.57] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +1.30 | [+1.05, +1.55] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.19 | [+1.06, +1.32] | |
➖ | http_elasticsearch | ingress throughput | +0.48 | [+0.33, +0.63] | |
➖ | fluent_elasticsearch | ingress throughput | +0.31 | [-0.19, +0.80] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.17 | [+0.05, +0.28] | |
➖ | http_to_http_json | ingress throughput | +0.14 | [+0.06, +0.22] | |
➖ | http_to_http_noack | ingress throughput | +0.10 | [+0.04, +0.17] | |
➖ | http_to_s3 | ingress throughput | +0.07 | [-0.22, +0.35] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.01 | [-0.07, +0.10] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.00 | [-0.10, +0.10] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.10, +0.09] | |
➖ | socket_to_socket_blackhole | ingress throughput | -0.23 | [-0.31, -0.15] | |
➖ | http_text_to_http_json | ingress throughput | -0.42 | [-0.55, -0.29] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.65 | [-0.76, -0.54] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -0.83 | [-0.92, -0.74] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.00 | [-1.10, -0.90] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -1.01 | [-1.10, -0.91] | |
➖ | http_to_http_acks | ingress throughput | -1.24 | [-2.46, -0.02] | |
➖ | splunk_hec_route_s3 | ingress throughput | -1.50 | [-1.82, -1.19] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -1.94 | [-2.10, -1.78] | |
➖ | otlp_http_to_blackhole | ingress throughput | -2.97 | [-3.10, -2.85] | |
❌ | file_to_blackhole | egress throughput | -16.30 | [-22.38, -10.21] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
We no longer host install.sh in AWS S3 but instead reference it from GitHub. This change happened a while ago, but we apparently never updated the CI wrokflow; we just never noticed since we haven't changed the script since then.