Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(new_relic sink)!: Drop event JSON parsing #21322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(new_relic sink)!: Drop event JSON parsing #21322

wants to merge 1 commit into from

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Sep 19, 2024

The new_relic sink has a feature when sending to the New Relic event API that it will look for a field named message and attempt to parse it as JSON. As this feature is not documented and duplicates functionality available through VRL, this change removes that complication.

@bruceg bruceg added type: tech debt A code change that does not add user value. meta: breaking change Anything that breaks backward compatibility. provider: new relic Anything `new relic` service provider related domain: logs Anything related to Vector's log events labels Sep 19, 2024
@bruceg bruceg requested a review from a team as a code owner September 19, 2024 14:22
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 19, 2024
@bruceg
Copy link
Member Author

bruceg commented Sep 19, 2024

@asllop I see this feature was added in the original PR #9764 that created this sink, but there doesn't appear to be any discussion of why it is present nor documentation for it. We are wondering if you have any comment on this issue.

@bruceg
chore(new_relic sink)!: Drop event JSON parsing
c7f2d4d 
The `new_relic` sink has a feature when sending to the New Relic event API that
it will look for a field named `message` and attempt to parse it as JSON. As
this feature is not documented and duplicates functionality available through
VRL, this change removes that complication.
@bruceg bruceg force-pushed the bruceg/drop-new-relic-json-parsing branch from a8639fe to c7f2d4d Compare September 19, 2024 14:36
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: bruceg/drop-new-relic-json-parsing
Commit report: f3dac94
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.55s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko Awaiting requested review from jszwedko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
domain: logs Anything related to Vector's log events domain: sinks Anything related to the Vector's sinks meta: breaking change Anything that breaks backward compatibility. provider: new relic Anything `new relic` service provider related type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bruceg