Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dedupe): add two test cases #21306

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore(dedupe): add two test cases #21306

merged 1 commit into from
Sep 17, 2024

Conversation

pront
Copy link
Contributor

@pront pront commented Sep 17, 2024

No description provided.

@pront pront requested a review from a team as a code owner September 17, 2024 19:06
@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label Sep 17, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 17, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/test-dedupe
Commit report: 1b0a775
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.51s Total Time

@pront pront added this pull request to the merge queue Sep 17, 2024
Copy link

Regression Detector Results

Run ID: 2ba1e881-6945-4eb1-bf85-219bc2eb12bb Metrics dashboard

Baseline: 0291b64
Comparison: da1d02d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +8.90 [+2.21, +15.59]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +8.90 [+2.21, +15.59]
syslog_loki ingress throughput +2.56 [+2.47, +2.64]
syslog_splunk_hec_logs ingress throughput +1.17 [+1.06, +1.28]
http_to_http_acks ingress throughput +0.63 [-0.60, +1.86]
socket_to_socket_blackhole ingress throughput +0.50 [+0.45, +0.55]
splunk_hec_route_s3 ingress throughput +0.48 [+0.15, +0.81]
http_elasticsearch ingress throughput +0.43 [+0.27, +0.58]
otlp_http_to_blackhole ingress throughput +0.33 [+0.22, +0.44]
syslog_log2metric_humio_metrics ingress throughput +0.32 [+0.24, +0.40]
http_to_http_noack ingress throughput +0.15 [+0.07, +0.23]
http_to_http_json ingress throughput +0.08 [+0.01, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.07, +0.08]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.12, +0.12]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.00 [-0.10, +0.09]
otlp_grpc_to_blackhole ingress throughput -0.33 [-0.44, -0.22]
datadog_agent_remap_blackhole ingress throughput -0.34 [-0.52, -0.16]
http_to_s3 ingress throughput -0.42 [-0.69, -0.15]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.63 [-0.77, -0.49]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.99 [-1.10, -0.88]
datadog_agent_remap_blackhole_acks ingress throughput -1.15 [-1.26, -1.04]
http_text_to_http_json ingress throughput -1.19 [-1.30, -1.07]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.26 [-1.38, -1.14]
fluent_elasticsearch ingress throughput -1.54 [-2.02, -1.05]
syslog_regex_logs2metric_ddmetrics ingress throughput -2.33 [-2.48, -2.19]
datadog_agent_remap_datadog_logs ingress throughput -3.05 [-3.25, -2.85]
syslog_humio_logs ingress throughput -4.40 [-4.50, -4.29]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit da1d02d Sep 17, 2024
68 of 70 checks passed
@pront pront deleted the pront/test-dedupe branch September 17, 2024 22:11
pront added a commit that referenced this pull request Sep 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2024
Revert "chore(dedupe): add two test cases (#21306)"

This reverts commit da1d02d.
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Revert "chore(dedupe): add two test cases (vectordotdev#21306)"

This reverts commit da1d02d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants