Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(external docs): Emphasize the $$ rather than $ in config file. #20991

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

iFurySt
Copy link
Contributor

@iFurySt iFurySt commented Aug 2, 2024

image image

Even though the replace function documentation already states that $$ should be used instead of $ in configuration files, the specific use case example does not emphasize this distinction. This can easily lead to misunderstandings, especially for newcomers. Since many people will use this in configuration files, I believe it is necessary to explicitly clarify the different usage in the specific use case example.

related issue: #20988

@iFurySt iFurySt requested review from a team as code owners August 2, 2024 15:36
@bits-bot
Copy link

bits-bot commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Aug 2, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iFurySt . This should avoid some confusion as this is the most common place users have run into problems with $s needing to be escaped.

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 2, 2024
@jszwedko jszwedko enabled auto-merge August 2, 2024 18:46
@jszwedko jszwedko added this pull request to the merge queue Aug 2, 2024
Merged via the queue into vectordotdev:master with commit 210ff09 Aug 2, 2024
64 of 66 checks passed
ym pushed a commit to ym/vector that referenced this pull request Aug 18, 2024
…ectordotdev#20991)

* docs: Emphasize the $$ rather than $ in config file.

* Update website/cue/reference/remap/functions/replace.cue

Co-authored-by: Ursula Chen <[email protected]>

---------

Co-authored-by: Jesse Szwedko <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
…ectordotdev#20991)

* docs: Emphasize the $$ rather than $ in config file.

* Update website/cue/reference/remap/functions/replace.cue

Co-authored-by: Ursula Chen <[email protected]>

---------

Co-authored-by: Jesse Szwedko <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants