Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(datadog_logs sink): default to zstd compression #19456

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dsmith3197
Copy link
Contributor

@dsmith3197 dsmith3197 commented Dec 22, 2023

#18526

This needs to be tested.

@dsmith3197 dsmith3197 requested review from a team as code owners December 22, 2023 18:39
@dsmith3197 dsmith3197 requested a review from a team December 22, 2023 18:39
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Dec 22, 2023
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@dsmith3197
Copy link
Contributor Author

/ci-run-regression

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Dec 22, 2023

Datadog Report

Branch report: dougsmith/datadog-default-zstd
Commit report: 426c604

vector: 1 Failed (0 Known Flaky), 0 New Flaky, 2077 Passed, 0 Skipped, 9m 6.49s Wall Time

❌ Failed Tests (1)

  • sinks::datadog::traces::apm_stats::integration_tests::apm_stats_e2e_test_dd_agent_to_vector_correctness - vector - Details

    Expand for error
     Test has failed
    

Copy link

Regression Detector Results

Run ID: 9565fde1-a9b1-47c0-85cf-a5da2a04797a
Baseline: af4de5e
Comparison: b0af10d
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • datadog_agent_remap_datadog_logs
  • datadog_agent_remap_datadog_logs_acks

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_splunk_hec_metrics ingress throughput +1.91 [+1.75, +2.06]
datadog_agent_remap_blackhole_acks ingress throughput +1.63 [+1.52, +1.74]
http_elasticsearch ingress throughput +1.14 [+1.06, +1.21]
syslog_humio_logs ingress throughput +1.13 [+1.02, +1.23]
datadog_agent_remap_blackhole ingress throughput +1.08 [+0.98, +1.18]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.80 [+0.71, +0.88]
syslog_splunk_hec_logs ingress throughput +0.70 [+0.66, +0.75]
otlp_grpc_to_blackhole ingress throughput +0.40 [+0.30, +0.50]
splunk_hec_route_s3 ingress throughput +0.27 [-0.26, +0.79]
http_to_http_noack ingress throughput +0.12 [+0.02, +0.21]
http_to_http_json ingress throughput +0.04 [-0.03, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.11]
enterprise_http_to_http ingress throughput -0.12 [-0.20, -0.04]
http_to_s3 ingress throughput -0.20 [-0.48, +0.07]
http_text_to_http_json ingress throughput -0.23 [-0.35, -0.10]
socket_to_socket_blackhole ingress throughput -0.24 [-0.33, -0.15]
syslog_loki ingress throughput -0.24 [-0.30, -0.18]
http_to_http_acks ingress throughput -0.27 [-1.58, +1.04]
fluent_elasticsearch ingress throughput -0.45 [-0.92, +0.03]
file_to_blackhole egress throughput -0.79 [-3.36, +1.78]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.81 [-0.93, -0.70]
otlp_http_to_blackhole ingress throughput -1.19 [-1.34, -1.04]
syslog_log2metric_humio_metrics ingress throughput -2.21 [-2.36, -2.05]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review required

@dsmith3197 dsmith3197 changed the title enhancement(datadog_logs sink, datadog_traces sink): default to zstd compression enhancement(datadog_logs sink): default to zstd compression Jan 11, 2024
@jszwedko jszwedko added the meta: awaiting author Pull requests that are awaiting their author. label Feb 14, 2024
@jszwedko jszwedko requested a review from a team as a code owner October 3, 2024 18:54
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Oct 3, 2024
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-regression

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Oct 4, 2024

Datadog Report

Branch report: dougsmith/datadog-default-zstd
Commit report: 746780c
Test service: vector

❌ 1 Failed (0 Known Flaky), 8 Passed, 0 Skipped, 2m 0.01s Total Time

❌ Failed Tests (1)

  • components::validation::tests::validate_component_tests_validation_components_sinks_datadog_logs_yaml - vector - Details

    Expand for error
     Test has failed
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants