Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC(B3TRGovernor & XAllocationPool): Add ability to toggle QF and QF on or off #19

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

roisindowling
Copy link
Contributor

Align public repo with latest version of contracts on mainnet

  • B3TRGovernor V3: Add functionality to toggle Quadratic Voting or or off by admin
  • XAllocationPool V2 : Add functionality to toggle Quadratic Funding or or off by admin

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.53740% with 579 lines in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (05df3ae) to head (f64d1b9).

Files with missing lines Patch % Lines
contracts/deprecated/V2/B3TRGovernorV2.sol 8.67% 221 Missing ⚠️
contracts/deprecated/V1/B3TRGovernorV1.sol 37.19% 152 Missing ⚠️
...1/governance/libraries/GovernorProposalLogicV1.sol 53.94% 70 Missing ⚠️
contracts/deprecated/V1/XAllocationPoolV1.sol 60.64% 61 Missing ⚠️
...V1/governance/libraries/GovernorConfiguratorV1.sol 6.89% 27 Missing ⚠️
...d/V1/governance/libraries/GovernorVotesLogicV1.sol 64.10% 14 Missing ⚠️
...d/V1/governance/libraries/GovernorStateLogicV1.sol 76.31% 9 Missing ⚠️
.../libraries/GovernorFunctionRestrictionsLogicV1.sol 63.63% 8 Missing ⚠️
...V1/governance/libraries/GovernorDepositLogicV1.sol 78.78% 7 Missing ⚠️
...d/V1/governance/libraries/GovernorClockLogicV1.sol 37.50% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #19       +/-   ##
===========================================
- Coverage   94.50%   80.18%   -14.32%     
===========================================
  Files          39       52       +13     
  Lines        2601     3664     +1063     
  Branches      561      525       -36     
===========================================
+ Hits         2458     2938      +480     
- Misses        142      725      +583     
  Partials        1        1               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roisindowling roisindowling marked this pull request as ready for review September 16, 2024 10:20
@roisindowling roisindowling requested a review from a team as a code owner September 16, 2024 10:20
@roisindowling roisindowling merged commit f82f4af into main Sep 20, 2024
5 checks passed
@roisindowling roisindowling deleted the toggleQF/QV branch September 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants