golang lint

.github/workflows/golang-ci.yml

@@ -6,11 +6,9 @@ on:
   push:
     branches:
       - main
-      - master
   pull_request:
     branches:
       - main
-      - master
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
 
@@ -34,7 +32,6 @@ jobs:
         uses: actions/setup-go@v4
         with:
           go-version: 1.21
-      - name: build broker
-        run: go build -o chat-broker ./cmd/broker
-      - name: build logic
-        run: go build -o chat-logic ./cmd/logic
+      - name: build
+        run: go build -o autotest ./
+

.golangci.yml

@@ -23,3 +23,4 @@ run:
     - test
     - example
     - cmd
+    - docker-compose

internal/command/http_automate.go

@@ -121,6 +121,7 @@ func HandleSingleFile(workerNum int, filePath string) *ResultInfo {
 		}
 
 		finishCount++
+		//nolint: errcheck
 		bar.Percent(float64(finishCount) / float64(len(testcases)) * 100)
 		if finishCount >= len(testcases) {
 			// finish all test cases

internal/command/http_call.go

@@ -75,10 +75,11 @@ func (m *HttpTestCallable) Call(ctx context.Context) *executor.GPResult {
 		return &r
 	}
 
-	ctx, cancel := context.WithTimeout(context.Background(), resource.GlobalConfig.Global.RequestTimeout)
+	timeout := resource.GlobalConfig.Global.RequestTimeout
+	rCtx, cancel := context.WithTimeout(ctx, timeout)
 	defer cancel()
 
-	in := resource.RestyClient.R().SetContext(ctx)
+	in := resource.RestyClient.R().SetContext(rCtx)
 	for _, item := range req.Headers {
 		strList := strings.Split(item, ":")
 		in.SetHeader(strings.TrimSpace(strList[0]), strings.TrimSpace(strList[1]))
@@ -125,9 +126,8 @@ func (m *HttpTestCallable) Call(ctx context.Context) *executor.GPResult {
 	}
 
 	// verify
-	VerifyResult := true
 	for idx, rule := range m.testcase.VerifyRules {
-		VerifyResult = rule.Verify(out)
+		VerifyResult := rule.Verify(out)
 		if !VerifyResult {
 			zaplog.Error("HttpTestCallable rules validate failed",
 				zap.Uint64("testCaseId", m.testcase.ID),

internal/rule/http_rule_test.go

@@ -19,7 +19,7 @@ func TestHttpBodyAtLeastOneRule(t *testing.T) {
 	resp.SetBody([]byte(jsonStr1))
 	for _, item := range cases {
 		rule := HttpBodyAtLeastOneRule{item.xpath, item.expected}
-		assert.True(t, rule.Valid(&resp))
+		assert.True(t, rule.Verify(&resp))
 	}
 }
 
@@ -36,7 +36,7 @@ func TestHttpBodyEqualRule(t *testing.T) {
 	resp.SetBody([]byte(jsonStr1))
 	for _, item := range cases {
 		rule := HttpBodyEqualRule{item.xpath, item.expected}
-		assert.True(t, rule.Valid(&resp))
+		assert.True(t, rule.Verify(&resp))
 	}
 
 }
@@ -55,6 +55,6 @@ func TestHttpBodyEqualRule2(t *testing.T) {
 	resp.SetBody([]byte(jsonStr2))
 	for _, item := range cases {
 		rule := HttpBodyEqualRule{item.xpath, item.expected}
-		assert.True(t, rule.Valid(&resp))
+		assert.True(t, rule.Verify(&resp))
 	}
 }