Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change how we determine the extensions #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dirkx
Copy link

@dirkx dirkx commented Jan 17, 2022

to deal with things like foo.ino.hex; or foo.sig.hex which are increasingly common. (Fixes #150)

…ino.hex; or foo.sig.hex which are increasingly common. (Fixes vdudouyt#150)
@spth
Copy link
Collaborator

spth commented Jan 17, 2022

This changes a use of strrchr to rindex. strrchr is standard C. rindex is POSIX only. And rindex is even deprecated in POSIX since 2008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension detection is a bit naive
2 participants