Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change value types to string #5

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Change value types to string #5

merged 1 commit into from
Jun 1, 2024

Conversation

acomanescu
Copy link
Contributor

This pr changes the value types from int to string to match the invoice.total value type.

@acomanescu
Copy link
Contributor Author

Related issue #5.

I believe this should be float64 instead of string.

@vcraescu
Copy link
Owner

vcraescu commented Jun 1, 2024

Related issue #5.

I believe this should be float64 instead of string.

It can't be float64 because of the precision issues the float has. It can be an int multiplied by 10000 since these are accounting documents or string which is inconvenient for the user.

@vcraescu vcraescu merged commit a235ea2 into vcraescu:master Jun 1, 2024
1 check passed
@vcraescu
Copy link
Owner

vcraescu commented Jun 1, 2024

thanks 👍

@acomanescu acomanescu mentioned this pull request Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acomanescu @vcraescu