Skip to content

Commit

Permalink
sagemathgh-37702: Workaround for multiprocessing shared memory limits
Browse files Browse the repository at this point in the history
This affects musl libc and macos, see:
sagemath#36741 (comment)

We are working on a better fix to avoid using multiprocessing in
sage.features (cf
sagemath#36741 (comment)),
but this will do meanwhile.

There is agreement that disabling the lock is completely harmless, since
the counter is not really used for anything; disabling the lock fixes
the issues that we had on 10.4.beta0.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

URL: sagemath#37702
Reported by: Gonzalo Tornaría
Reviewer(s): Sebastian Oehms
  • Loading branch information
Release Manager committed Mar 31, 2024
2 parents e026973 + 7a65d53 commit 850ed07
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=461fc89608a23f5e06c75bdd0a7480527fc3fa66
md5=94145a9c6e55496266631d06c3d7fdeb
cksum=613494009
sha1=48bc6e2a97fbe3f4c243bb4d2ae9b2290d2ffb1b
md5=50711242ccc3dbf90ae9018d1b1eeb9e
cksum=3666009533
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e9456b2da71c424d3ff188d5bb75e3c60f42be16
40019799db820be4fc4738af1dae97b992c9de55
2 changes: 1 addition & 1 deletion src/sage/features/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def __init__(self, name, spkg=None, url=None, description=None, type='optional')
# shared among subprocesses. Thus we use the Value class from the
# multiprocessing module (cf. self._seen of class AvailableSoftware)
from multiprocessing import Value
self._num_hidings = Value('i', 0)
self._num_hidings = Value('i', 0, lock=False)

try:
from sage.misc.package import spkg_type
Expand Down

0 comments on commit 850ed07

Please sign in to comment.