Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 4 unnecessary stubbings in OidcClientTest.java #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ARUS2023
Copy link

@ARUS2023 ARUS2023 commented Oct 5, 2023

In our analysis of the project, we observed that

  1. 3 unnecessary stubbings which stubbed getUserInfo, getTokenResponse(returned tokenResponse) and getUserInfoResponse are created but never executed by 2 tests: OidcClientTest.userInfoErrorResponse, OidcClientTest.userInfoErrorResponseWithoutErrorCode;

  2. 1 unnecessary stubbing which stubbed getTokenResponse (returned invalidTokenResponse) is created but never executed by 1 test: OidcClientTest.getUserInfoFromUserInfoEndpoint;

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

@ARUS2023 ARUS2023 changed the title Removed 3 unnecessary stubbings in OidcClientTest.java Removed 4 unnecessary stubbings in OidcClientTest.java Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant