Merge pull request #13662 from uckelman/more_finals

PMD: Variables can be final
vassalengine · Oct 29, 2024 · a3c428a · a3c428a
2 parents e487464 + aa5ae56
commit a3c428a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/vassal-app/src/main/java/VASSAL/script/ExpressionInterpreter.java b/vassal-app/src/main/java/VASSAL/script/ExpressionInterpreter.java
@@ -1116,7 +1116,7 @@ public Object countMapLocation(Object locationName, Object mapName, Object prope
     final PieceFilter filter = createFilter(expression, ps);
     final Map targetMap = findVassalMap(mapName.toString());
 
-    String propValue;
+    final String propValue;
     if (property == null || property.toString().isEmpty()) {
       propValue = null;
     }
@@ -1251,7 +1251,7 @@ public Object countZone(Object zoneName, Object mapName, Object property, Object
     final PieceFilter filter = createFilter(expression, ps);
     final Map targetMap = findVassalMap(mapName.toString());
 
-    String propValue;
+    final String propValue;
     if (property == null || property.toString().isEmpty()) {
       propValue = null;
     }

diff --git a/vassal-app/src/main/java/VASSAL/tools/DataArchive.java b/vassal-app/src/main/java/VASSAL/tools/DataArchive.java
@@ -322,7 +322,7 @@ protected SortedSet<String> getLocalImageNames() {
 
   /* Localized directories always take the form images_XX with XX being a i18n code */
   protected void buildLocalizedDirectoryList(List<String> list) {
-    List<String> files;
+    final List<String> files;
     try {
       files = archive.getFiles("");
     }

diff --git a/vassal-app/src/main/java/VASSAL/tools/PropertiesEncoder.java b/vassal-app/src/main/java/VASSAL/tools/PropertiesEncoder.java
@@ -42,7 +42,7 @@ public PropertiesEncoder(String stringValue) throws IOException {
   }
 
   private String encode(Properties p) {
-    String s;
+    final String s;
     try {
       final ByteArrayOutputStream out = new ByteArrayOutputStream();
       p.store(out, null);