Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move V1L private pointer from wrk to the vdp entry #4219

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor: Move V1L private pointer from wrk to the vdp entry #4219

wants to merge 4 commits into from

Commits on Nov 1, 2024

  1. cache_http1_line: Refactor V1L_Open() to return struct v1l *

    @nigoroll
    nigoroll committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    48e2fd2 View commit details
    Browse the repository at this point in the history

  2. cache_http1_line: Make the v1l VDP a bit less special 

    V1L is used to send HTTP headers and the body, so it is used directly from
delivery/fetch first and then as a VDP.

From the times before VDPs, the V1L VDP still had its private pointer in struct
wrk.

This commit is to move the private pointer to the VDP entry. The caller remains
responsible for calling V1L_Close() to keep V1L independent of VDP.
    @nigoroll
    nigoroll committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fccbcb0 View commit details
    Browse the repository at this point in the history

  3. cache_http1_line: Flexelint: Avoid unchecked downcast 

    Found with less Flexelint silencing
    @nigoroll
    nigoroll committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    698201a View commit details
    Browse the repository at this point in the history

  4. cache_http1_line: Flexelint: signedness polish and other minor improv… 

    …ements

Found with less Flexelint silencing

Change of data type of struct v1l members was guided by their main use:

{s,n,c}iov are all related to the iovcnt argument of writev(), which is
of type int.

{l,cl}iov are lengths (to be) written, which can not be negative.

cnt is ultimately going to be returned as a uint64_t, so it makes sense
to have that in the first place.

The other changes are consequences of these, fixing all sign and type
related Flexelint complaints.
    @nigoroll
    nigoroll committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a308ad9 View commit details
    Browse the repository at this point in the history